You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2006/01/10 05:43:33 UTC

[PATCH] mod_proxy_fcgi - s/fcgi-tcp:/fcgi:/

As we get further into implementing this stuff, it seems more and more
silly to have more than one scheme for fastcgi.  Any non-tcp mechanism
is going to require more info than we can easily get out of the URL
anyway, since we're already using the path portion of the URL for
calculating the path_info, so we might as well just use fcgi:// URLs
and save people some typing.  When the time comes to implement fcgi
over unix domain sockets or pipes we'll be able to infer the socket
type needed from the ProxyPass parameters or some other similar means.

With that in mind, does anyone object to the following patch?

-garrett

Change the FastCGI URL scheme to fcgi://.

* modules/proxy/mod_proxy_fcgi.c
  (proxy_fcgi_canon): Stop pretending unix domain sockets will need their
   own url scheme.
  (FCGI_SCHEME): New constant to describe the FastCGI proxy backend.
  (proxy_fcgi_handler): Drop the fcgi-local stuff, use FCGI_SCHEME now that
   we aren't worrying about multiple types of FastCGI workers.

Re: [PATCH] mod_proxy_fcgi - s/fcgi-tcp:/fcgi:/

Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 1/9/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:

> With that in mind, does anyone object to the following patch?

Well, since nobody jumped up and down screaming "NO, NO, DON'T DO IT"
I committed this in r367906.

-garrett