You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/04 18:30:09 UTC
[GitHub] [airflow] JCoder01 commented on a change in pull request #5787:
[AIRFLOW-5172] Add choice of interval edge scheduling
JCoder01 commented on a change in pull request #5787: [AIRFLOW-5172] Add choice of interval edge scheduling
URL: https://github.com/apache/airflow/pull/5787#discussion_r318051340
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -649,7 +649,10 @@ def create_dag_run(self, dag, session=None):
if dag.schedule_interval == '@once':
period_end = next_run_date
elif next_run_date:
- period_end = dag.following_schedule(next_run_date)
+ if dag.schedule_at_interval_end:
+ period_end = dag.following_schedule(next_run_date)
+ else: # Schedule it at the start of the interval
+ period_end = next_run_date
Review comment:
Does similar logic need to be applied to manage_slas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services