You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (Created) (JIRA)" <ji...@apache.org> on 2011/10/20 23:19:11 UTC
[jira] [Created] (HBASE-4640) Catch ClosedChannelException and
document it
Catch ClosedChannelException and document it
--------------------------------------------
Key: HBASE-4640
URL: https://issues.apache.org/jira/browse/HBASE-4640
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Priority: Minor
Fix For: 0.94.0
ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4640) Catch ClosedChannelException and
document it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211134#comment-13211134 ]
Hudson commented on HBASE-4640:
-------------------------------
Integrated in HBase-TRUNK #2665 (See [https://builds.apache.org/job/HBase-TRUNK/2665/])
HBASE-4640 Catch ClosedChannelException and document it (Revision 1245730)
Result = FAILURE
jdcryans :
Files :
* /hbase/trunk/src/docbkx/troubleshooting.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
> Catch ClosedChannelException and document it
> --------------------------------------------
>
> Key: HBASE-4640
> URL: https://issues.apache.org/jira/browse/HBASE-4640
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4640.patch
>
>
> ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4640) Catch ClosedChannelException and
document it
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210825#comment-13210825 ]
Hudson commented on HBASE-4640:
-------------------------------
Integrated in HBase-TRUNK-security #114 (See [https://builds.apache.org/job/HBase-TRUNK-security/114/])
HBASE-4640 Catch ClosedChannelException and document it (Revision 1245730)
Result = FAILURE
jdcryans :
Files :
* /hbase/trunk/src/docbkx/troubleshooting.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
> Catch ClosedChannelException and document it
> --------------------------------------------
>
> Key: HBASE-4640
> URL: https://issues.apache.org/jira/browse/HBASE-4640
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4640.patch
>
>
> ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4640) Catch ClosedChannelException and
document it
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210483#comment-13210483 ]
stack commented on HBASE-4640:
------------------------------
+1
On commit add the CCE.getMessage to the LOG.WARN just in case its got info of use (I'm fine on skipping stack trace)
> Catch ClosedChannelException and document it
> --------------------------------------------
>
> Key: HBASE-4640
> URL: https://issues.apache.org/jira/browse/HBASE-4640
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4640.patch
>
>
> ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4640) Catch ClosedChannelException and
document it
Posted by "Jean-Daniel Cryans (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-4640.
---------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed to trunk with Stack's commit, thanks for the review.
> Catch ClosedChannelException and document it
> --------------------------------------------
>
> Key: HBASE-4640
> URL: https://issues.apache.org/jira/browse/HBASE-4640
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4640.patch
>
>
> ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4640) Catch ClosedChannelException and
document it
Posted by "Jean-Daniel Cryans (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans reassigned HBASE-4640:
-----------------------------------------
Assignee: Jean-Daniel Cryans
> Catch ClosedChannelException and document it
> --------------------------------------------
>
> Key: HBASE-4640
> URL: https://issues.apache.org/jira/browse/HBASE-4640
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4640.patch
>
>
> ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4640) Catch ClosedChannelException and
document it
Posted by "Jean-Daniel Cryans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-4640:
--------------------------------------
Attachment: HBASE-4640.patch
Patch that does what I described. The new message for ClosedChannelException is a bit different from the one I added in the book, but it still fits and currently users will likely hit the old version of the message.
I targeted this for 0.94 but I'm confident that it's harmless for 0.92
> Catch ClosedChannelException and document it
> --------------------------------------------
>
> Key: HBASE-4640
> URL: https://issues.apache.org/jira/browse/HBASE-4640
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: HBASE-4640.patch
>
>
> ClosedChannelException is a pretty obscure exception for the non-expert and doesn't tell you why you get it. We should instead catch it, print a WARN, don't print a stack trace, and add a line in the book about this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira