You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2026/03/06 16:17:00 UTC

[jira] [Resolved] (SOLR-17549) Reconsider error-handling in generated-v2 SolrResponses

     [ https://issues.apache.org/jira/browse/SOLR-17549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gerlowski resolved SOLR-17549.
------------------------------------
    Fix Version/s: main(11.0)
         Assignee: Jason Gerlowski
       Resolution: Fixed

Alright, closing this out!

I think "Option 1" as I described it above is worth doing in the longer-term even with the "Option 2" fix in place here.  But that's really about NamedList reduction more than "error handling" per se, so it needn't be in this ticket.

> Reconsider error-handling in generated-v2 SolrResponses
> -------------------------------------------------------
>
>                 Key: SOLR-17549
>                 URL: https://issues.apache.org/jira/browse/SOLR-17549
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrJ, v2 API
>    Affects Versions: 10.0
>            Reporter: Jason Gerlowski
>            Assignee: Jason Gerlowski
>            Priority: Blocker
>              Labels: V2, pull-request-available
>             Fix For: main(11.0), 10.1
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> In most cases upon receiving an HTTP response, SolrClients will immediately parse it into a NamedList and then inspect that NamedList to see whether a client-side exception should be triggered.
> Our generated v2-API SolrRequest/SolrResponse classes work differently.  They never convert the response into a NamedList, instead using Jackson to put it into a strongly-typed POJO.  -Additionally, response parsing occurs lazily - typically not until after the SolrResponse has been returned to callers and they've invoked a special "getParsed()" method.-
> The combined effect of these two differences is that all of the error-detection/exception-throwing code in SolrClient is skipped when making generated-v2 requests!  Callers can still detect errors by manually inspecting their response POJOs, but anyone expecting SolrJ's "no exception means success" convention are in for a frustrating shock.
> We should change how response-parsing happens in the generated-v2 case to match the rest of SolrJ.  (Or alternately - investigate some more intuitive way to communicate failure.)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org