[GitHub] jlahoda commented on issue #1144: NB build with jdk11

[GitBox <gi...@apache.org>]

jlahoda commented on issue #1144: NB build with jdk11
URL: https://github.com/apache/incubator-netbeans/pull/1144#issuecomment-467177305
 
 
   > Avoiding the compilation of Javac during NetBeans build is in my opinion desirable. CCing @jlahoda... The `nb-javac-*-*.jar` files can only be used during compilation, but as far as I know it is the case.
   
   Would be good to see the compilation go away, but:
   -just using nb-javac will simply mean the baseline JDK on which we can run without nb-javac is JDK 12. If that's the move we want to make, I am fairly sure some changes elsewhere will be needed as well. (NoJavacHelper and ergonomics come to mind,)
   -using nb-javac(-impl) will mean the modules (besides java.source.nbjavac) might accidentally use some nb-javac specific API, which would hamper the ability to run without nb-javac.
   
   These are the main reasons why the build compiles against a vanilla/unmodified javac. The reason why the build compiles it from source is that then the conditions of the javac license are met vacuously, I believe.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists