You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Bryant Luk (JIRA)" <ji...@apache.org> on 2009/09/17 02:58:57 UTC
[jira] Created: (WINK-192) Should come up with plan for injection
on client side
Should come up with plan for injection on client side
-----------------------------------------------------
Key: WINK-192
URL: https://issues.apache.org/jira/browse/WINK-192
Project: Wink
Issue Type: Bug
Components: Client
Affects Versions: 0.2
Reporter: Bryant Luk
Fix For: 0.2
I don't know if maybe we should tag this with WINK-162, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-192) Should come up with plan for injection
on client side
Posted by "Nick Gallardo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Gallardo updated WINK-192:
-------------------------------
Fix Version/s: (was: 0.2)
Thanks for the proposal Bryant. Given that we're not going to completely address this one in 1.0, I'll move this to a later release.
> Should come up with plan for injection on client side
> -----------------------------------------------------
>
> Key: WINK-192
> URL: https://issues.apache.org/jira/browse/WINK-192
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Attachments: WINK-192.patch
>
>
> I don't know if maybe we should tag this with WINK-166, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
> Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
> I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-192) Should come up with plan for injection
on client side
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-192:
----------------------------
Attachment: WINK-192.patch
At least a proposed fix for the first issue.
> Should come up with plan for injection on client side
> -----------------------------------------------------
>
> Key: WINK-192
> URL: https://issues.apache.org/jira/browse/WINK-192
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-192.patch
>
>
> I don't know if maybe we should tag this with WINK-166, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
> Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
> I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-192) Should come up with plan for injection
on client side
Posted by "Nick Gallardo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Gallardo updated WINK-192:
-------------------------------
Issue Type: Improvement (was: Bug)
> Should come up with plan for injection on client side
> -----------------------------------------------------
>
> Key: WINK-192
> URL: https://issues.apache.org/jira/browse/WINK-192
> Project: Wink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.0
> Reporter: Bryant Luk
> Attachments: WINK-192.patch
>
>
> I don't know if maybe we should tag this with WINK-166, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
> Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
> I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WINK-192) Should come up with plan for injection
on client side
Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryant Luk updated WINK-192:
----------------------------
Description:
I don't know if maybe we should tag this with WINK-166, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
was:
I don't know if maybe we should tag this with WINK-162, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
> Should come up with plan for injection on client side
> -----------------------------------------------------
>
> Key: WINK-192
> URL: https://issues.apache.org/jira/browse/WINK-192
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-192.patch
>
>
> I don't know if maybe we should tag this with WINK-166, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
> Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
> I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WINK-192) Should come up with plan for injection
on client side
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WINK-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763332#action_12763332 ]
Hudson commented on WINK-192:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #207 (See [http://hudson.zones.apache.org/hudson/job/Wink-Trunk-JDK1.5/207/])
Insert the ProvidersRegistry into RuntimeContext
See []
> Should come up with plan for injection on client side
> -----------------------------------------------------
>
> Key: WINK-192
> URL: https://issues.apache.org/jira/browse/WINK-192
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.2
> Reporter: Bryant Luk
> Fix For: 0.2
>
> Attachments: WINK-192.patch
>
>
> I don't know if maybe we should tag this with WINK-166, but the RuntimeContext should get set before invoking the client's request's HandlerContext chain. A handler such as AcceptHeaderHandler can invoke a Provider's isReadable (say wink-json-providers) before the ProvidersRegistry is put on the RuntimeContextTLS during the readEntity/writeEntity on the client.
> Should implement UriInfo and other JAX-RS interfaces to allow the widest range of readers/writers on the client. Otherwise, if a provider is injected with one of the Context interfaces, a NPE will occur for them as well (i.e. wink-json-providers)
> I haven't thought this all the way through but another problem is that HttpHeaders is really intended for use on the server side only. I imagine some of the generic provider logic for entity providers would not work correctly (say a HttpHeaders.getAcceptableMediaTypes() is called during the writeTo() of an entity provider).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.