[GitHub] wu-sheng commented on a change in pull request #1372: Accept multi entry spans in collector analysis

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #1372: Accept multi entry spans in collector analysis
URL: https://github.com/apache/incubator-skywalking/pull/1372#discussion_r196995096
 
 

 ##########
 File path: apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/dao/ui/SegmentDurationShardingjdbcUIDAO.java
 ##########
 @@ -141,7 +141,8 @@ public TraceBrief loadTop(long startSecondTimeBucket, long endSecondTimeBucket,
                 basicTrace.setSegmentId(rs.getString(SegmentDurationTable.SEGMENT_ID.getName()));
                 basicTrace.setDuration(rs.getInt(SegmentDurationTable.DURATION.getName()));
                 basicTrace.setStart(rs.getLong(SegmentDurationTable.START_TIME.getName()));
-                basicTrace.setOperationName(rs.getString(SegmentDurationTable.SERVICE_NAME.getName()));
+                //TODO linjiaqi operation name was changed to contains multiple values
 
 Review comment:
   Submit an issue for @chidaodezhongsheng , please.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services