[GitHub] [arrow-datafusion] kazuyukitanimura opened a new issue, #6907: Write tests for streaming_merge

["kazuyukitanimura (via GitHub)" <gi...@apache.org>]

kazuyukitanimura opened a new issue, #6907:
URL: https://github.com/apache/arrow-datafusion/issues/6907

   ### Is your feature request related to a problem or challenge?
   
   With #6874, `physical_plan::merge::streaming_merge` is now public. 
   
   Without some care, the change may be lost in some future refactoring (e.g. if the code is moved to another module, for example, that is not pub).
   
   ### Describe the solution you'd like
   
   Write a test, perhaps as an example of how to use this API, in: https://github.com/apache/arrow-datafusion/tree/main/datafusion-examples/examples
   
   Might be able to adapt some of the existing code in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/fuzz_cases/merge_fuzz.rs or https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/benches/sort.rs
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] viirya commented on issue #6907: Write tests for streaming_merge

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on issue #6907:
URL: https://github.com/apache/arrow-datafusion/issues/6907#issuecomment-1629645107

   Yea, it is good to add test for public API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org