You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/05/13 19:57:36 UTC
Re: Review Request 20285: Improve documentation and testing for host
maintenance API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20285/#review42851
-----------------------------------------------------------
Update or discard?
- Bill Farner
On April 12, 2014, 11:45 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20285/
> -----------------------------------------------------------
>
> (Updated April 12, 2014, 11:45 p.m.)
>
>
> Review request for Aurora, David Robinson, Kevin Sweeney, Tobias Weingartner, and Bill Farner.
>
>
> Bugs: AURORA-318
> https://issues.apache.org/jira/browse/AURORA-318
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add way more docstrings as well as unit tests for the HostMaintenance api.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 6a21ddeb4203a07a04360f68c4a338fe3da52c70
> src/test/python/apache/aurora/admin/BUILD 17aac54d636024a8e131eb2e4d996c2e15401de1
> src/test/python/apache/aurora/admin/test_host_maintenance.py 95497aea3d3f769b2460adbfe7a7b72d775ced6f
>
> Diff: https://reviews.apache.org/r/20285/diff/
>
>
> Testing
> -------
>
> 16:39:58 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all
> Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/admin/BUILD:all)])
> ============================================================================================================ test session starts =============================================================================================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 9 items
>
> src/test/python/apache/aurora/admin/test_host_maintenance.py .........
>
> ========================================================================================================== 9 passed in 0.67 seconds ==========================================================================================================
> src.test.python.apache.aurora.admin.host_maintenance ..... SUCCESS
>
>
> Thanks,
>
> Joe Smith
>
>