You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/04/24 11:21:00 UTC

Review Request 58661: Refactored test filter handling in stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58661/
-----------------------------------------------------------

Review request for mesos, Joseph Wu, Neil Conway, and Till Toenshoff.


Repository: mesos


Description
-------

This refactoring will make it easier to create test filters in
libprocess and Mesos. Furthermore the code has been updated to follow
stout's coding style.


Diffs
-----

  3rdparty/stout/include/stout/tests/environment.hpp 61dfe0dd894759de50c5e925923def40cd1fe809 
  3rdparty/stout/tests/main.cpp fbbe8393782ed6cc8de66d7d6439d08772a73a55 


Diff: https://reviews.apache.org/r/58661/diff/1/


Testing
-------

make check


Thanks,

Jan Schlicht

Re: Review Request 58661: Refactored test filter handling in stout.

Posted by Neil Conway <ne...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58661/#review172796
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On April 24, 2017, 11:20 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58661/
> -----------------------------------------------------------
> 
> (Updated April 24, 2017, 11:20 a.m.)
> 
> 
> Review request for mesos, Joseph Wu, Neil Conway, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This refactoring will make it easier to create test filters in
> libprocess and Mesos. Furthermore the code has been updated to follow
> stout's coding style.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/tests/environment.hpp 61dfe0dd894759de50c5e925923def40cd1fe809 
>   3rdparty/stout/tests/main.cpp fbbe8393782ed6cc8de66d7d6439d08772a73a55 
> 
> 
> Diff: https://reviews.apache.org/r/58661/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>