You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "stephen mallette (JIRA)" <ji...@apache.org> on 2018/07/25 16:28:00 UTC

[jira] [Closed] (TINKERPOP-1969) Embedded list assertions do not work for Gherkin tests in Python

     [ https://issues.apache.org/jira/browse/TINKERPOP-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stephen mallette closed TINKERPOP-1969.
---------------------------------------
    Resolution: Won't Do

No need to complicate the gherkin runner any further - i reworked the test to not require it:

https://github.com/apache/tinkerpop/commit/3be3550d191fc894639cfe2aae5447eb7bad3cbf

> Embedded list assertions do not work for Gherkin tests in Python
> ----------------------------------------------------------------
>
>                 Key: TINKERPOP-1969
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1969
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: python
>    Affects Versions: 3.2.9
>            Reporter: stephen mallette
>            Priority: Trivial
>
> The parsing of embedded list assertions for Gherkin test isn't quite up to par and therefor a test has to be ignored for the suite to pass:
> https://github.com/apache/tinkerpop/commit/29eef8977a17955040b7c7921c1ebb20ed65325b#diff-b36232a680402ccca9d4d199366c251fR46
> Specifically, it does not like this type of assertion:
> https://github.com/apache/tinkerpop/commit/29eef8977a17955040b7c7921c1ebb20ed65325b#diff-bc849673baf1f7ed925db681d0cc112cR672
> I don't think it would be crazy to refactor the parsing for in general for assertions - maybe there is a nicer way:
> https://github.com/apache/tinkerpop/commit/29eef8977a17955040b7c7921c1ebb20ed65325b#diff-b36232a680402ccca9d4d199366c251fR155



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)