You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/27 06:50:18 UTC
[GitHub] [phoenix] stoty opened a new pull request, #1504: pPHOENIX-5066 The TimeZone is incorrectly used during writing or readi…
stoty opened a new pull request, #1504:
URL: https://github.com/apache/phoenix/pull/1504
…ng data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] dbwong commented on pull request #1504: PHOENIX-5066 The TimeZone is incorrectly used during writing or readi…
Posted by GitBox <gi...@apache.org>.
dbwong commented on PR #1504:
URL: https://github.com/apache/phoenix/pull/1504#issuecomment-1313278023
I had a high level question on your approach. Your email used thread local variable for somewhat global access, i worry if our execution engine becomes more multi threaded you will have to copy this to all the threads and become more and more cumbersome. I'm hesitant of such patterns for things that are not semaphore like. I assume the resistance in the code is from our lack of structure and not wanting to pass a parameter everywhere. I think another approach is possible with a provider pattern given the connection and some jvm level singleton map. Did you consider this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1504: PHOENIX-5066 The TimeZone is incorrectly used during writing or readi…
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1504:
URL: https://github.com/apache/phoenix/pull/1504#issuecomment-1457717713
Abandoning in favor of the WITHOUT TIMEZONE solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1504: PHOENIX-5066 The TimeZone is incorrectly used during writing or readi…
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty closed pull request #1504: PHOENIX-5066 The TimeZone is incorrectly used during writing or readi…
URL: https://github.com/apache/phoenix/pull/1504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org