You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/05 11:32:13 UTC

[GitHub] [druid] wjhypo commented on a change in pull request #11307: Add an option to enable bitmap in IncrementalIndex during real time ingestion

wjhypo commented on a change in pull request #11307:
URL: https://github.com/apache/druid/pull/11307#discussion_r645979759



##########
File path: processing/src/main/java/org/apache/druid/segment/QueryableIndexStorageAdapter.java
##########
@@ -270,7 +270,8 @@ public VectorCursor makeVectorCursor(
       VirtualColumns virtualColumns,
       Granularity gran,
       boolean descending,
-      @Nullable QueryMetrics<?> queryMetrics
+      @Nullable QueryMetrics<?> queryMetrics,
+      boolean useInMemoryBitmapInQuery

Review comment:
       Hi Frank, this case is caused by `IncrementalIndexStorageAdapter` and `QueryableIndexStorageAdapter` extending the same interface and lots of other classes implementing the same interface introduced changes accordingly as well. However, based on the previous discussion on the necessity of `useInMemoryBitmapInQuery`, this param probably can be omitted and just use `enableInMemoryBitmap` as the only switch, let me remove this param and simplify the code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org