You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/02/29 17:44:45 UTC
[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1740
[FLINK-3538] Streamline Scala DataStream.join/coGroup
This enforces that the user always has to specify keys for both inputs
before .window() can be called.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink scala-stream-join-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1740
----
commit 70391df2979ee59d6ddad96c8fcb0e6a5a74ebf1
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2016-02-29T16:02:38Z
[FLINK-3538] Streamline Scala DataStream.join/coGroup
This enforces that the user always has to specify keys for both inputs
before .window() can be called.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1740#issuecomment-190305207
Changes look good to me. Good work @aljoscha :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1740#issuecomment-190299923
Code looks good. Let's see if Travis agrees.
This code is *Binary-API-Breaking, but not *Source-API-Breaking*, correct? Can you tag the commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1740#issuecomment-190315085
I think it's simply "api breaking". Will add the tag and merge. ok? Will then also put it on the release-1.0 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1740#issuecomment-190303294
I think the changes are source API breaking since the return type of `where`, `equalTo` and `join` changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3538] Streamline Scala DataStream.join/...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---