You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/10/02 07:01:19 UTC

[GitHub] [dubbo-hessian-lite] tianshuang opened a new pull request, #60: Fix broken unit tests due to strict Serializable interface restrictions

tianshuang opened a new pull request, #60:
URL: https://github.com/apache/dubbo-hessian-lite/pull/60

   Because `java.util.Map` and `java.util.Set` do not implement the Serializable interface, but https://github.com/apache/dubbo-hessian-lite/commit/99d689cf47c00b664db89bc8dff44dcd595b6ea6 imposes strict restrictions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo-hessian-lite] codecov-commenter commented on pull request #60: Fix broken unit tests due to strict Serializable interface restrictions

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #60:
URL: https://github.com/apache/dubbo-hessian-lite/pull/60#issuecomment-1264569602

   # [Codecov](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/60?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#60](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/60?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e24501b) into [master](https://codecov.io/gh/apache/dubbo-hessian-lite/commit/b8d2a8ecdf2ee589c7250dced19eafc7c6bed674?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d2a8e) will **increase** coverage by `0.08%`.
   > The diff coverage is `75.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master      #60      +/-   ##
   ============================================
   + Coverage     27.77%   27.85%   +0.08%     
   - Complexity      561      566       +5     
   ============================================
     Files            93       93              
     Lines          6485     6487       +2     
     Branches       1077     1078       +1     
   ============================================
   + Hits           1801     1807       +6     
   + Misses         4449     4445       -4     
     Partials        235      235              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ibaba/com/caucho/hessian/io/SerializerFactory.java](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/60/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9jb20vY2F1Y2hvL2hlc3NpYW4vaW8vU2VyaWFsaXplckZhY3RvcnkuamF2YQ==) | `69.56% <75.00%> (+1.21%)` | :arrow_up: |
   | [...a/com/caucho/hessian/io/AbstractHessianOutput.java](https://codecov.io/gh/apache/dubbo-hessian-lite/pull/60/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9jb20vY2F1Y2hvL2hlc3NpYW4vaW8vQWJzdHJhY3RIZXNzaWFuT3V0cHV0LmphdmE=) | `33.33% <0.00%> (+3.33%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org