Re: [PR] fix(hive): Remove unused async arg from execute query func to get hive connector working [superset]

["bkyryliuk (via GitHub)" <gi...@apache.org>]

bkyryliuk commented on code in PR #24984:
URL: https://github.com/apache/superset/pull/24984#discussion_r1350506563


##########
superset/db_engine_specs/hive.py:
##########
@@ -542,11 +542,9 @@ def update_impersonation_config(
             connect_args["configuration"] = configuration
 
     @staticmethod
-    def execute(  # type: ignore
-        cursor, query: str, async_: bool = False
-    ):  # pylint: disable=arguments-differ
-        kwargs = {"async": async_}
-        cursor.execute(query, **kwargs)
+    def execute(cursor, query: str):

Review Comment:
   Yes, I need to specify catalog in the connection string and see the schemas in the catalog:
   conn string
   ```
   databricks+connector://token:{token}@{host}:{port}/{catalog}?catalog={catalog}
   ```
   
   ```
   {"connect_args":{"http_path":"/sql/1.0/warehouses/{id}","catalog":"{catalog}"}}
   ```
   
   I got a bit lazy and did not fully figure out what setting is actually setting the catalog and I think that has changed over time with databricks connector
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org