You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "rickchengx (via GitHub)" <gi...@apache.org> on 2023/06/15 03:58:54 UTC

[GitHub] [dolphinscheduler] rickchengx opened a new pull request, #14355: [Improvement-14354][Parameter] Rename Property to Parameter

rickchengx opened a new pull request, #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Purpose of the pull request
   
   * close: #14354 
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   * Rename `Property` to `Parameter`
   * Rename `prop` to `key`
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   <img width="591" alt="截屏2023-06-15 11 55 08" src="https://github.com/apache/dolphinscheduler/assets/38122586/f6669ce2-fb9d-4875-9b39-0296e8497bfc">
   
   <img width="577" alt="截屏2023-06-15 10 37 34" src="https://github.com/apache/dolphinscheduler/assets/38122586/dfe7c128-05d1-4387-a7df-82c2ee22942b">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] rickchengx commented on a diff in pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx commented on code in PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#discussion_r1231813284


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/Parameter.java:
##########
@@ -23,13 +23,13 @@
 import java.io.Serializable;
 import java.util.Objects;
 
-public class Property implements Serializable {
+public class Parameter implements Serializable {
 
     private static final long serialVersionUID = -4045513703397452451L;
     /**
      * key
      */
-    private String prop;
+    private String key;

Review Comment:
   @ruanwenjun I got you. So it seems that `prop` should remain unchanged, and only rename `Property` to `Parameter`, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#issuecomment-1592454394

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14355)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=CODE_SMELL)
   
   [![44.6%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png '44.6%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_coverage&view=list) [44.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_coverage&view=list)  
   [![0.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.1%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_duplicated_lines_density&view=list) [0.1% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#issuecomment-1592442543

   ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#14355](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (55f4488) into [dev](https://app.codecov.io/gh/apache/dolphinscheduler/commit/c1a67905149a1d791ec23dca477bc59c08c4f607?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c1a6790) will **increase** coverage by `0.00%`.
   > The diff coverage is `48.28%`.
   
   > :exclamation: Current head 55f4488 differs from pull request most recent head abddb7e. Consider uploading reports for the commit abddb7e to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##                dev   #14355   +/-   ##
   =========================================
     Coverage     38.47%   38.48%           
   + Complexity     4559     4555    -4     
   =========================================
     Files          1237     1237           
     Lines         43538    43493   -45     
     Branches       4814     4782   -32     
   =========================================
   - Hits          16753    16739   -14     
   + Misses        24932    24904   -28     
   + Partials       1853     1850    -3     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...eduler/api/dto/workflow/WorkflowCreateRequest.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by93b3JrZmxvdy9Xb3JrZmxvd0NyZWF0ZVJlcXVlc3QuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...eduler/api/dto/workflow/WorkflowUpdateRequest.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2R0by93b3JrZmxvdy9Xb3JrZmxvd1VwZGF0ZVJlcXVlc3QuamF2YQ==) | `36.36% <ø> (ø)` | |
   | [...api/service/impl/ProcessDefinitionServiceImpl.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzRGVmaW5pdGlvblNlcnZpY2VJbXBsLmphdmE=) | `35.43% <0.00%> (ø)` | |
   | [...er/master/builder/TaskExecutionContextBuilder.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9idWlsZGVyL1Rhc2tFeGVjdXRpb25Db250ZXh0QnVpbGRlci5qYXZh) | `67.24% <ø> (ø)` | |
   | [...erver/master/runner/StreamTaskExecuteRunnable.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvU3RyZWFtVGFza0V4ZWN1dGVSdW5uYWJsZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...er/runner/execute/TaskExecutionContextFactory.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvZXhlY3V0ZS9UYXNrRXhlY3V0aW9uQ29udGV4dEZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...master/runner/task/switchtask/SwitchLogicTask.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvdGFzay9zd2l0Y2h0YXNrL1N3aXRjaExvZ2ljVGFzay5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...er/service/subworkflow/SubWorkflowServiceImpl.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2Uvc3Vid29ya2Zsb3cvU3ViV29ya2Zsb3dTZXJ2aWNlSW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...he/dolphinscheduler/service/utils/ProcessData.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3NlcnZpY2UvdXRpbHMvUHJvY2Vzc0RhdGEuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...dolphinscheduler/plugin/task/api/AbstractTask.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL2FwaS9BYnN0cmFjdFRhc2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [41 more](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14355/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#discussion_r1230937872


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/model/Parameter.java:
##########
@@ -23,13 +23,13 @@
 import java.io.Serializable;
 import java.util.Objects;
 
-public class Property implements Serializable {
+public class Parameter implements Serializable {
 
     private static final long serialVersionUID = -4045513703397452451L;
     /**
      * key
      */
-    private String prop;
+    private String key;

Review Comment:
   It seems this pr will change the metadata structure, we need to refresh the whole data in db.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] rickchengx closed pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx closed pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter
URL: https://github.com/apache/dolphinscheduler/pull/14355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#issuecomment-1592338370

   Hi, can we modify parameter name, either?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#issuecomment-1592451522

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=14355)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=14355&resolved=false&types=CODE_SMELL)
   
   [![44.6%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png '44.6%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_coverage&view=list) [44.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_coverage&view=list)  
   [![0.1%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.1%')](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_duplicated_lines_density&view=list) [0.1% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=14355&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#discussion_r1230407857


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-python/src/main/java/org/apache/dolphinscheduler/plugin/task/python/PythonTask.java:
##########
@@ -170,11 +170,11 @@
     protected String buildPythonScriptContent() throws Exception {
         log.info("raw python script : {}", pythonParameters.getRawScript());
         String rawPythonScript = pythonParameters.getRawScript().replaceAll("\\r\\n", System.lineSeparator());
-        Map<String, Property> paramsMap = mergeParamsWithContext(pythonParameters);
+        Map<String, Parameter> paramsMap = mergeParamsWithContext(pythonParameters);
         return ParameterUtils.convertParameterPlaceholders(rawPythonScript, ParameterUtils.convert(paramsMap));
     }
 
-    protected Map<String, Property> mergeParamsWithContext(AbstractParameters parameters) {
+    protected Map<String, Parameter> mergeParamsWithContext(AbstractParameters parameters) {

Review Comment:
   ## Useless parameter
   
   The parameter 'parameters' is never used.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2977)



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -453,7 +453,7 @@
      * @param rgex rgex
      * @param sqlParamsMap sql params map
      */
-    private void printReplacedSql(String content, String formatSql, String rgex, Map<Integer, Property> sqlParamsMap) {
+    private void printReplacedSql(String content, String formatSql, String rgex, Map<Integer, Parameter> sqlParamsMap) {

Review Comment:
   ## Useless parameter
   
   The parameter 'rgex' is never used.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2979)



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -453,7 +453,7 @@
      * @param rgex rgex
      * @param sqlParamsMap sql params map
      */
-    private void printReplacedSql(String content, String formatSql, String rgex, Map<Integer, Property> sqlParamsMap) {
+    private void printReplacedSql(String content, String formatSql, String rgex, Map<Integer, Parameter> sqlParamsMap) {

Review Comment:
   ## Useless parameter
   
   The parameter 'content' is never used.
   
   [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2978)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] rickchengx commented on pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx commented on PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#issuecomment-1592388525

   > Hi, can we modify parameter name, either?
   
   Sure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] Radeity commented on pull request #14355: [Improvement-14354][Parameter] Rename Property to Parameter

Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on PR #14355:
URL: https://github.com/apache/dolphinscheduler/pull/14355#issuecomment-1592520278

   > > Hi, can we modify parameter name, either?
   > 
   > @Radeity Sure, you mean sth like this?
   > 
   > <img alt="image" width="464" src="https://user-images.githubusercontent.com/38122586/246002824-12a67edb-5c0a-4ab5-8d2c-09fc2b22881f.png">
   
   Yes, that's clear now, thanks for your effort :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org