[GitHub] [kafka] hachikuji commented on a diff in pull request #13230: KAFKA-14704; Follower should truncate before incrementing high watermark

["hachikuji (via GitHub)" <gi...@apache.org>]

hachikuji commented on code in PR #13230:
URL: https://github.com/apache/kafka/pull/13230#discussion_r1103426128


##########
core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala:
##########
@@ -1089,6 +1089,85 @@ class AbstractFetcherThreadTest {
     fetcher.verifyLastFetchedEpoch(partition, Some(5))
   }
 
+  @Test
+  def testTruncateOnFetchDoesNotUpdateHighWatermark(): Unit = {

Review Comment:
   nit: wonder if we should change the name. The test is not really doing anything with the high watermark; it is just verifying that `processPartitionData` is not called. Maybe a test like this could exist for `ReplicaFetcherThread`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org