You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2021/05/17 12:29:44 UTC

[GitHub] [incubator-streampipes-extensions] mohanvive opened a new pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

mohanvive opened a new pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47


   ### Purpose
   I have found some issues with the documentation, hence fixed them with this PR.
   
   Fixes https://issues.apache.org/jira/browse/STREAMPIPES-359
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] mohanvive commented on pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
mohanvive commented on pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47#issuecomment-842285273


   @dominikriemer @tenthe @grainier 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] mohanvive commented on a change in pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
mohanvive commented on a change in pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47#discussion_r633606471



##########
File path: streampipes-processors-filters-jvm/src/main/resources/org.apache.streampipes.processors.filters.jvm.merge/documentation.md
##########
@@ -38,12 +38,11 @@ The following figure shows how the events of the two data streams will be mergrg
 
 ## Required input
 Each of the data streams needs a timestamp.
-***

Review comment:
       It is a mistake. I have fixed it now. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] mohanvive commented on a change in pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
mohanvive commented on a change in pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47#discussion_r633606471



##########
File path: streampipes-processors-filters-jvm/src/main/resources/org.apache.streampipes.processors.filters.jvm.merge/documentation.md
##########
@@ -38,12 +38,11 @@ The following figure shows how the events of the two data streams will be mergrg
 
 ## Required input
 Each of the data streams needs a timestamp.
-***

Review comment:
       It is a mistake. I have fixed it now. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] dominikriemer merged pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
dominikriemer merged pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] grainier commented on a change in pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
grainier commented on a change in pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47#discussion_r633554613



##########
File path: streampipes-processors-filters-jvm/src/main/resources/org.apache.streampipes.processors.filters.jvm.merge/documentation.md
##########
@@ -38,12 +38,11 @@ The following figure shows how the events of the two data streams will be mergrg
 
 ## Required input
 Each of the data streams needs a timestamp.
-***

Review comment:
       @mohanvive Do we have to remove this? If so, some documentation files still seem to have `***` under required-input sections. We might have to remove them as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] grainier commented on a change in pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
grainier commented on a change in pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47#discussion_r633554613



##########
File path: streampipes-processors-filters-jvm/src/main/resources/org.apache.streampipes.processors.filters.jvm.merge/documentation.md
##########
@@ -38,12 +38,11 @@ The following figure shows how the events of the two data streams will be mergrg
 
 ## Required input
 Each of the data streams needs a timestamp.
-***

Review comment:
       @mohanvive Do we have to remove this? If so, some documentation files still seem to have `***` under required-input sections. We might have to remove them as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-streampipes-extensions] mohanvive commented on pull request #47: [STREAMPIPES-359] Fix issues on pipeline elements documentation

Posted by GitBox <gi...@apache.org>.
mohanvive commented on pull request #47:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/47#issuecomment-842285273


   @dominikriemer @tenthe @grainier 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org