You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/06/03 23:23:05 UTC
Re: Review Request: OOZIE-1394 Fix bugs around missing fields in events
> On May 30, 2013, 6:30 p.m., Mona Chitnis wrote:
> > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java, lines 100-103
> > <https://reviews.apache.org/r/11533/diff/1/?file=298438#file298438line100>
> >
> > all suspended actions are loaded on a Resume command. It would be a good idea to have these fields in the STARTED message then
The missing dependencies will be empty when a suspended action is moved to running. So this is redundant.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11533/#review21202
-----------------------------------------------------------
On May 30, 2013, 2:02 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11533/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 2:02 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1394
>
> Patch fixes following
> 1. Added missing Coord Action Start event on Rerun/Resume
> 2. Fixed missing parentId and nominaltime fields by modifying DB Query that populates the CoordAction bean used to construct event
>
>
> This addresses bug OOZIE-1394.
> https://issues.apache.org/jira/browse/OOZIE-1394
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/TransitionXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 1487638
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsRunningJPAExecutor.java 1487638
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSuspendedJPAExecutor.java 1487638
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1487638
>
> Diff: https://reviews.apache.org/r/11533/diff/
>
>
> Testing
> -------
>
> added test for coord rerun/resume case.
>
>
> Thanks,
>
> Mona Chitnis
>
>