[GitHub] [calcite] jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet

[GitBox <gi...@apache.org>]

jh3507 commented on a change in pull request #1309: [CALCITE-3183] Trimming method for Filter rel uses wrong traitSet
URL: https://github.com/apache/calcite/pull/1309#discussion_r301698493
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
 ##########
 @@ -303,6 +303,10 @@ public RelNode createAggregate(RelNode input,
   public interface FilterFactory {
     /** Creates a filter. */
     RelNode createFilter(RelNode input, RexNode condition);
+
+    /** Creates a filter. */
+    RelNode createFilter(RelNode input, RexNode condition,
 
 Review comment:
   Thanks for the suggestion. I think having a default method is a great idea since it wouldn't cause any compatibility issue and we don't need to provide additional implementations for other rels that don't have constructors for variablesSet. I updated the patch. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services