[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #1673: Entries Tables Working with Delete Manifests

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #1673:
URL: https://github.com/apache/iceberg/pull/1673#discussion_r513743779



##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntriesTable.java
##########
@@ -112,28 +113,36 @@ protected long targetSplitSize(TableOperations ops) {
       ResidualEvaluator residuals = ResidualEvaluator.unpartitioned(filter);
 
       return CloseableIterable.transform(manifests, manifest ->
-          new ManifestReadTask(ops.io(), manifest, fileSchema, schemaString, specString, residuals));
+          new ManifestReadTask(ops.io(), manifest, fileSchema, schemaString, specString, residuals, ops.current()
+              .specsById()));

Review comment:
       Sounds good to me, My preferred is new lines for every arg every time :) But I think this is reasonable too




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org