[GitHub] [cordova] raphinesse edited a comment on issue #91: --nosave flag causes errors when adding platforms/plugins

[GitBox <gi...@apache.org>]

raphinesse edited a comment on issue #91: --nosave flag causes errors when adding platforms/plugins
URL: https://github.com/apache/cordova/issues/91#issuecomment-478555601
 
 
   Thank you for creating this issue @asgoth . Actually I noticed this bug myself just a short while ago but forgot to create an issue.
   
   Then, I also did some research on what exactly is broken. In short: some versions of `npm` automatically prune installed packages during installation (https://github.com/npm/npm/issues/16853). This means that if you run `npm i --no-save A` followed by `npm i --no-save B` you have no guarantee to still have A or any of its dependencies installed. This completely breaks our `--no-save` option. This problem also seems to have bitten Cordova users before: https://github.com/npm/npm/issues/16853#issuecomment-368287473. However, I cannot confirm that recent `npm` versions have reliably fixed the pruning issue.
   
   My preferred course of action would be to just remove our `--no-save` option altogether. Firstly, because I do not know how we could fix this and secondly because it does not play well with Cordova workflows that I would recommend. But since you were using it, would you care to share your use-case for this option?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org