[GitHub] [maven-surefire] cardil edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console

[GitBox <gi...@apache.org>]

cardil edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498011714
 
 
   >  I have a question to the new constant RANDOM_SEED in BooterConstants. Was is necessary. Could it be transfered in the value of randomOrder?
   
   This property is used to pass a computed random seed to forked process with Booter Serializer/Deserializer. Passing just run order is insufficient. When user do not pass a seed, I generate one and use it to order tests and print it on console.
   
   I can modify runOrder value, bu i feel like that's code smell. Better to leave it in original value and add additional parameter as exact seed - genereted or given.
   
   Example: User gives `-Dsurefire.runOrder=random`. I generate seed, say: `128312` and pass `runOrder => random, seed => 128312` to forked process. When user gives `-Dsurefire.runOrder=random:128312`, I reuse seed given and pass `runOrder => random:128312, seed => 128312` to forked process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services