You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ravipesala <gi...@git.apache.org> on 2014/10/24 14:23:14 UTC
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
GitHub user ravipesala opened a pull request:
https://github.com/apache/spark/pull/2926
[SPARK-3814][SQL] Support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) in Spark HQL and SQL
Currently there is no support of Bitwise & , | in Spark HiveQl and Spark SQL as well. So this PR support the same.
I am closing https://github.com/apache/spark/pull/2789 as it has conflicts to merge. And also added support for Bitwise AND(&), OR(|) ,XOR(^), NOT(~) And I handled all review comments in that PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/spark SPARK-3814-NEW3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2926.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2926
----
commit 90ebbe095476246ffbb159ad5461cd5990348589
Author: ravipesala <ra...@huawei.com>
Date: 2014-10-24T12:17:35Z
Rebased with master and handled comments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60535381
[Test build #467 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/467/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch **does not merge cleanly**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60475319
[Test build #437 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/437/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60379940
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala closed the pull request at:
https://github.com/apache/spark/pull/2926
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60537966
This LGTM. Can you please merge with master and push to this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60403156
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22139/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60476825
[Test build #437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/437/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseNot(child: Expression) extends UnaryExpression `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60538544
[Test build #467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/467/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch **passes all tests**.
* This patch **does not merge cleanly**.
* This patch adds the following public classes _(experimental)_:
* `case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseNot(child: Expression) extends UnaryExpression `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60394505
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60395218
[Test build #22139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22139/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60537951
[Test build #460 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/460/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseNot(child: Expression) extends UnaryExpression `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60403147
[Test build #22139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22139/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class BitwiseAnd(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseOr(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseXor(left: Expression, right: Expression) extends BinaryArithmetic `
* `case class BitwiseNot(child: Expression) extends UnaryExpression `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60644904
Closed this PR and created new PR https://github.com/apache/spark/pull/2961 after rebasing with master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3814][SQL] Support for Bitwise AND(&), ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2926#issuecomment-60534826
[Test build #460 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/460/consoleFull) for PR 2926 at commit [`90ebbe0`](https://github.com/apache/spark/commit/90ebbe095476246ffbb159ad5461cd5990348589).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org