You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/02/26 06:43:19 UTC
Review Request 31468: LENS-348 : Remove unnecessary class level locks
in QueryExecutionServiceImpl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31468/
-----------------------------------------------------------
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-348
https://issues.apache.org/jira/browse/LENS-348
Repository: lens
Description
-------
Removes synchronized on getMetrics() and getStatisticsService(), which are not required
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 82cfaf4
Diff: https://reviews.apache.org/r/31468/diff/
Testing
-------
mvn clean package -DskipTests works. Running all tests, will update once done.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31468: LENS-348 : Remove unnecessary class level
locks in QueryExecutionServiceImpl
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31468/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 7:42 a.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-348
https://issues.apache.org/jira/browse/LENS-348
Repository: lens
Description
-------
Removes synchronized on getMetrics() and getStatisticsService(), which are not required.
The only class level locks now are :
public synchronized void init(HiveConf hiveConf)
public synchronized void stop()
public synchronized void start()
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 82cfaf4
Diff: https://reviews.apache.org/r/31468/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.056s]
[INFO] Lens .............................................. SUCCESS [1.693s]
[INFO] Lens API .......................................... SUCCESS [5.580s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.318s]
[INFO] Lens Cube ......................................... SUCCESS [6:26.782s]
[INFO] Lens DB storage ................................... SUCCESS [9.117s]
[INFO] Lens Query Library ................................ SUCCESS [4.576s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:36.421s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [25.319s]
[INFO] Lens Server ....................................... SUCCESS [4:21.720s]
[INFO] Lens client ....................................... SUCCESS [20.578s]
[INFO] Lens CLI .......................................... SUCCESS [1:56.798s]
[INFO] Lens Examples ..................................... SUCCESS [0.999s]
[INFO] Lens Distribution ................................. SUCCESS [9.388s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.907s]
[INFO] Lens Regression ................................... SUCCESS [0.457s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:31.635s
[INFO] Finished at: Thu Feb 26 07:22:57 UTC 2015
[INFO] Final Memory: 108M/1081M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31468: LENS-348 : Remove unnecessary class level
locks in QueryExecutionServiceImpl
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31468/#review74223
-----------------------------------------------------------
Ship it!
Ship It!
- Jaideep dhok
On Feb. 26, 2015, 5:45 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31468/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 5:45 a.m.)
>
>
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
>
>
> Bugs: LENS-348
> https://issues.apache.org/jira/browse/LENS-348
>
>
> Repository: lens
>
>
> Description
> -------
>
> Removes synchronized on getMetrics() and getStatisticsService(), which are not required.
>
> The only class level locks now are :
> public synchronized void init(HiveConf hiveConf)
> public synchronized void stop()
> public synchronized void start()
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 82cfaf4
>
> Diff: https://reviews.apache.org/r/31468/diff/
>
>
> Testing
> -------
>
> mvn clean package -DskipTests works. Running all tests, will update once done.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31468: LENS-348 : Remove unnecessary class level
locks in QueryExecutionServiceImpl
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31468/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 5:45 a.m.)
Review request for lens, Jaideep dhok and Rajat Khandelwal.
Bugs: LENS-348
https://issues.apache.org/jira/browse/LENS-348
Repository: lens
Description (updated)
-------
Removes synchronized on getMetrics() and getStatisticsService(), which are not required.
The only class level locks now are :
public synchronized void init(HiveConf hiveConf)
public synchronized void stop()
public synchronized void start()
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 82cfaf4
Diff: https://reviews.apache.org/r/31468/diff/
Testing
-------
mvn clean package -DskipTests works. Running all tests, will update once done.
Thanks,
Amareshwari Sriramadasu