You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/03 05:04:11 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #10504: More tweaks needed after adding Doctype tag
rusackas opened a new pull request #10504:
URL: https://github.com/apache/incubator-superset/pull/10504
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Mainly, fixes a bug with the FilterBox in the Explore view. Also consolidates a few bits of styling, and adds 'px' to some font size styles that should have had them in the first place.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
After screenshots, now working:
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: bug found by @ktmud, as commented in #10302
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10504: fix: More tweaks needed after adding Doctype tag
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10504:
URL: https://github.com/apache/incubator-superset/pull/10504
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10504: fix: More tweaks needed after adding Doctype tag
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10504:
URL: https://github.com/apache/incubator-superset/pull/10504#issuecomment-673639632
Fixes https://github.com/apache/incubator-superset/issues/10589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10504: fix: More tweaks needed after adding Doctype tag
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10504:
URL: https://github.com/apache/incubator-superset/pull/10504#discussion_r464656869
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -193,12 +198,12 @@ class Chart extends React.PureComponent {
onError={this.handleRenderContainerFailure}
showMessage={false}
>
- <div
- className={`chart-container ${isLoading ? 'is-loading' : ''}`}
- style={containerStyles}
- >
+ <Styles className={`chart-container`}>
Review comment:
Can use `className="chart-container"`. I'm surprised ESLint didn't catch this.
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -193,12 +198,12 @@ class Chart extends React.PureComponent {
onError={this.handleRenderContainerFailure}
showMessage={false}
>
- <div
- className={`chart-container ${isLoading ? 'is-loading' : ''}`}
- style={containerStyles}
- >
+ <Styles className={`chart-container`}>
<div className={`slice_container ${isFaded ? ' faded' : ''}`}>
- <ChartRenderer {...this.props} />
+ <ChartRenderer
+ {...this.props}
+ data-test={JSON.stringify(this.props)}
Review comment:
Do we need the full `props` for test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org