You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/06/26 14:46:00 UTC

[jira] [Commented] (NIFI-11743) Restrict FlowRegistryClient API to not allow null returns

    [ https://issues.apache.org/jira/browse/NIFI-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737182#comment-17737182 ] 

ASF subversion and git services commented on NIFI-11743:
--------------------------------------------------------

Commit 5c8f4bf70cd19c8d056217d864fdad5df7e746ae in nifi's branch refs/heads/main from Simon Bence
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5c8f4bf70c ]

NIFI-11743 Adding restrictions on return values of FlowRegistryClient

This closes #7431

Signed-off-by: David Handermann <ex...@apache.org>


> Restrict FlowRegistryClient API to not allow null returns
> ---------------------------------------------------------
>
>                 Key: NIFI-11743
>                 URL: https://issues.apache.org/jira/browse/NIFI-11743
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Simon Bence
>            Assignee: Simon Bence
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The current definition of FlowRegistryClient allows implementations to return with a null value in cases such as list of buckets, flows or versions. In practice, this will not happen, but future implementations of changes has this option now.
> This is something we want to eliminate both because it is considered as a bad pattern and because NiFi expect a valid (but maybe empty) return value. From code perspective this will not cause any change, but the document will be extended accordingly and will communicate that null is not a valid return value.
> Even if this is not a code change and the current registry client behaves in this manner, it is considered as a breaking change thus this will be part of the 2.x line only.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)