You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Martin von Gagern <Ma...@gmx.net> on 2007/01/17 09:49:54 UTC
[PATCH] Re: slash after dir in bash_completion
Hyrum K. Wright wrote:
> Martin,
> I have not reviewed your patch, however, I do have a suggestion. Your
> patch a much greater probability of being applied if you follow the
> guidelines in HACKING, especially regarding subject lines and log
> messages.
>
> Thanks,
> -Hyrum
OK, so here we go again. The same patch minus the trunk/ prefix plus the
log message, and PATCH in the subject line. Thanks for the hint, Hyrum!
For the verbose description of the problem as well as for some
discussion of alternatives I'd point readers at my original post:
http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=123044
The important thing is in the log message as well, of course.
Greetings,
Martin
Re: [PATCH] Re: slash after dir in bash_completion
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Hyrum K. Wright wrote:
> Martin von Gagern wrote:
>> OK, so here we go again. The same patch minus the trunk/ prefix plus the
>> log message, and PATCH in the subject line. Thanks for the hint, Hyrum!
>>
>> For the verbose description of the problem as well as for some
>> discussion of alternatives I'd point readers at my original post:
>> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=123044
>> The important thing is in the log message as well, of course.
>
> Has anybody had a chance to look at Martin's patch? If nobody comments in the
> next few days, I'll file it as an issue.
Filed as issue #2714.
-Hyrum
>> ------------------------------------------------------------------------
>>
>> [[[
>> * tools/client-side/bash_completion: Tell besh we are generating filenames
>> so that it puts a slash instead of a space after a directory name.
>> ]]]
>>
>> Index: tools/client-side/bash_completion
>> ===================================================================
>> --- tools/client-side/bash_completion (revision 23051)
>> +++ tools/client-side/bash_completion (working copy)
>> @@ -616,7 +616,7 @@
>> COMPREPLY=( $( compgen -W "$cmdOpts" -- $cur ) )
>> return 0
>> }
>> -complete -F _svn -o default svn
>> +complete -F _svn -o filenames svn
>>
>> _svnadmin ()
>> {
>> @@ -717,4 +717,4 @@
>>
>> return 0
>> }
>> -complete -F _svnadmin -o default svnadmin
>> +complete -F _svnadmin -o filenames svnadmin
>
>
Re: [PATCH] Re: slash after dir in bash_completion
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Martin von Gagern wrote:
> OK, so here we go again. The same patch minus the trunk/ prefix plus the
> log message, and PATCH in the subject line. Thanks for the hint, Hyrum!
>
> For the verbose description of the problem as well as for some
> discussion of alternatives I'd point readers at my original post:
> http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=123044
> The important thing is in the log message as well, of course.
Has anybody had a chance to look at Martin's patch? If nobody comments in the
next few days, I'll file it as an issue.
-Hyrum
> ------------------------------------------------------------------------
>
> [[[
> * tools/client-side/bash_completion: Tell besh we are generating filenames
> so that it puts a slash instead of a space after a directory name.
> ]]]
>
> Index: tools/client-side/bash_completion
> ===================================================================
> --- tools/client-side/bash_completion (revision 23051)
> +++ tools/client-side/bash_completion (working copy)
> @@ -616,7 +616,7 @@
> COMPREPLY=( $( compgen -W "$cmdOpts" -- $cur ) )
> return 0
> }
> -complete -F _svn -o default svn
> +complete -F _svn -o filenames svn
>
> _svnadmin ()
> {
> @@ -717,4 +717,4 @@
>
> return 0
> }
> -complete -F _svnadmin -o default svnadmin
> +complete -F _svnadmin -o filenames svnadmin