You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/09/25 18:14:55 UTC
[GitHub] activemq-artemis pull request #798: Build fixes
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/798
Build fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis build-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #798
----
commit 775862ee72984a31b130427d4e0c9af3afe68859
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-09-25T18:13:08Z
Add missing @Override
commit 494c85d624b306f27ca7e5de690f4ec6074a9d8d
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-09-25T18:13:29Z
Java 1.7 build fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #798: Build fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/798#discussion_r80690071
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java ---
@@ -1259,6 +1259,7 @@ public RoutingStatus send(final ServerMessage message, final boolean direct, boo
return send(getCurrentTransaction(), message, direct, noAutoCreateQueue);
}
+ @Override
--- End diff --
@scop I just started my day but I guess you came up with the same changes :)
nice one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #798: Build fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/798
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #798: Build fixes
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/798#discussion_r80397193
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java ---
@@ -1259,6 +1259,7 @@ public RoutingStatus send(final ServerMessage message, final boolean direct, boo
return send(getCurrentTransaction(), message, direct, noAutoCreateQueue);
}
+ @Override
--- End diff --
There is a way to avoid these on compile time, using Error Prone.
I have tried that, and I even had the changes... but we have some code generated.. we would need to ignore the generated code, or to make it also have overrides.
@scop Can we talk through IRC tomorrow, or google chat?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #798: Build fixes
Posted by scop <gi...@git.apache.org>.
Github user scop commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/798#discussion_r80623084
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java ---
@@ -1259,6 +1259,7 @@ public RoutingStatus send(final ServerMessage message, final boolean direct, boo
return send(getCurrentTransaction(), message, direct, noAutoCreateQueue);
}
+ @Override
--- End diff --
@clebertsuconic if you have your Error Prone changes still somewhere, maybe you can push them somewhere public, I'd be interested in taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---