You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/03 16:13:40 UTC
[GitHub] [incubator-mxnet] eric-haibin-lin opened a new pull request #18850: update setup.py
eric-haibin-lin opened a new pull request #18850:
URL: https://github.com/apache/incubator-mxnet/pull/18850
## Description ##
fixes https://github.com/apache/incubator-mxnet/issues/18849
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18850: update setup.py
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18850:
URL: https://github.com/apache/incubator-mxnet/pull/18850#discussion_r464608285
##########
File path: python/setup.py
##########
@@ -131,12 +131,8 @@ def config_cython():
'Intended Audience :: Education',
'Intended Audience :: Science/Research',
'License :: OSI Approved :: Apache Software License',
- 'Programming Language :: C++',
'Programming Language :: Cython',
- 'Programming Language :: Other', # R, Scala
- 'Programming Language :: Perl',
'Programming Language :: Python',
- 'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
Review comment:
we also no longer offer these and instead only support 3.6+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #18850: update setup.py
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18850:
URL: https://github.com/apache/incubator-mxnet/pull/18850#issuecomment-668235895
@mxnet-bot run ci [miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18850: update setup.py
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18850:
URL: https://github.com/apache/incubator-mxnet/pull/18850#issuecomment-668110161
Hey @eric-haibin-lin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [clang, edge, unix-gpu, sanity, unix-cpu, centos-gpu, website, centos-cpu, windows-gpu, miscellaneous, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18850: update setup.py
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18850:
URL: https://github.com/apache/incubator-mxnet/pull/18850#issuecomment-668235926
Jenkins CI successfully triggered : [miscellaneous]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #18850: update setup.py
Posted by GitBox <gi...@apache.org>.
eric-haibin-lin merged pull request #18850:
URL: https://github.com/apache/incubator-mxnet/pull/18850
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org