You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/01/26 01:37:29 UTC
[GitHub] jihoonson commented on a change in pull request #6830: Add null
checks in DruidSchema
jihoonson commented on a change in pull request #6830: Add null checks in DruidSchema
URL: https://github.com/apache/incubator-druid/pull/6830#discussion_r251182175
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -402,7 +402,7 @@ private void addSegment(final DruidServerMetadata server, final DataSegment segm
}
}
- private void removeSegment(final DataSegment segment)
+ protected void removeSegment(final DataSegment segment)
Review comment:
Please add `@VisibleForTesting` to newly exposed methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org