You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/30 02:35:29 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #5280: [INLONG-5279][Manager] Optimize the creation code of databases and tables

healchow commented on code in PR #5280:
URL: https://github.com/apache/inlong/pull/5280#discussion_r933718318


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/mysql/MySQLJdbcUtils.java:
##########
@@ -81,8 +82,8 @@ public static Connection getConnection(String url, String user, String password)
      */
     public static void executeSql(Connection conn, String sql) throws Exception {
         Statement stmt = conn.createStatement();
-        LOG.info("execute sql [{}] success !", sql);
         stmt.execute(sql);
+        LOG.info("execute sql [{}] success !", sql);

Review Comment:
   No need to add `!` in log info.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org