You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/05/26 01:13:06 UTC
Review Request 59601: Removed an unused declaration in type_utils.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
Repository: mesos
Description
-------
Removed an unused declaration in type_utils.hpp.
Diffs
-----
include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
Diff: https://reviews.apache.org/r/59601/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/#review176320
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59091, 59094, 59596, 59597, 59598, 59599, 59600, 59601]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 26, 2017, 1:13 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59601/
> -----------------------------------------------------------
>
> (Updated May 26, 2017, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an unused declaration in type_utils.hpp.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
>
>
> Diff: https://reviews.apache.org/r/59601/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/#review176166
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 26, 2017, 1:13 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59601/
> -----------------------------------------------------------
>
> (Updated May 26, 2017, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an unused declaration in type_utils.hpp.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
>
>
> Diff: https://reviews.apache.org/r/59601/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/#review176186
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59091, 59094, 59596, 59597, 59598, 59599, 59600, 59601]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 26, 2017, 1:13 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59601/
> -----------------------------------------------------------
>
> (Updated May 26, 2017, 1:13 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an unused declaration in type_utils.hpp.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
>
>
> Diff: https://reviews.apache.org/r/59601/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/
-----------------------------------------------------------
(Updated June 26, 2017, 4:28 a.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Removed an unused declaration in type_utils.hpp.
Diffs (updated)
-----
include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
Diff: https://reviews.apache.org/r/59601/diff/3/
Changes: https://reviews.apache.org/r/59601/diff/2-3/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/#review177457
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On June 9, 2017, 1:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59601/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 1:10 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an unused declaration in type_utils.hpp.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
>
>
> Diff: https://reviews.apache.org/r/59601/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/#review178694
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On June 9, 2017, 1:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59601/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 1:10 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an unused declaration in type_utils.hpp.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
>
>
> Diff: https://reviews.apache.org/r/59601/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/#review177460
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On June 9, 2017, 1:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59601/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 1:10 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an unused declaration in type_utils.hpp.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
>
>
> Diff: https://reviews.apache.org/r/59601/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59601: Removed an unused declaration in
type_utils.hpp.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59601/
-----------------------------------------------------------
(Updated June 8, 2017, 11:10 p.m.)
Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, Jan Schlicht, and Zhongbo Tian.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Removed an unused declaration in type_utils.hpp.
Diffs (updated)
-----
include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
Diff: https://reviews.apache.org/r/59601/diff/2/
Changes: https://reviews.apache.org/r/59601/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu