[GitHub] [ozone] SaketaChalamchala commented on a diff in pull request #5123: HDDS-7035. With virtual style addressing do not append bucketname from host to canonical URI for signature validation.

["SaketaChalamchala (via GitHub)" <gi...@apache.org>]

SaketaChalamchala commented on code in PR #5123:
URL: https://github.com/apache/ozone/pull/5123#discussion_r1294950316


##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/TestVirtualHostStyleFilter.java:
##########
@@ -106,7 +107,8 @@ public void testVirtualHostStyle() throws  Exception {
             ".localhost:9878", "/myfile", null, true);
     virtualHostStyleFilter.filter(containerRequest);
     URI expected = new URI("http://" + s3HttpAddr +
-        "/mybucket/myfile");
+        "/mybucket/myfile?" + S3Consts.ENDPOINT_STYLE_PARAM + "=" +
+        S3Consts.ENDPOINT_STYLE_VIRTUAL);

Review Comment:
   Thanks for the review @errose28 I added the extra parameters are added internally in VirtualHostStyleFilter.java so that when we do signature validation late we know to use the original request URI sent by the client and not the URI with bucket name that is appended in VirtualHostStyleFilter.java.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org