You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Santhosh Kumar Shanmugham <sa...@gmail.com> on 2018/06/15 17:58:32 UTC
Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Jordan Ly.
Repository: aurora
Description
-------
Convert SlaManager into an AbstractIdleService and explicitly
close the AsyncHttpClient on scheduler shutdown. Otherwise
we run the rise of having a stuck scheduler JVM that is unable
to shutdown due to any on the remaining non-daemon http client
threads.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
Diff: https://reviews.apache.org/r/67613/diff/1/
Testing
-------
./gradlew test
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204856
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On June 15, 2018, 5:58 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 5:58 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204879
-----------------------------------------------------------
Master (8383ed5) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 15, 2018, 1:59 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 1:59 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/3/
>
>
> Testing
> -------
>
> ./gradlew test
>
> **Tested in vagrant:**
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.456 [BlockingDriverJoin, StateMachine] SchedulerLifecycle state machine transition DEAD -> DEAD
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.457 [BlockingDriverJoin, SchedulerLifecycle] Shutdown already invoked, ignoring extra call.
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.458 [TearDownShutdownRegistry STOPPING, StateMachine] storage state machine transition READY -> STOPPED
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, Lifecycle] Shutting down application
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, ShutdownRegistry$ShutdownRegistryImpl] Action controller has already completed, subsequent calls ignored.
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.461 [main, SchedulerMain] Stopping scheduler services.
> **Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.470 [SlaManager$$EnhancerByGuice$$40d3047 STOPPING, SlaManager] Shutting down SlaManager async http client.**
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.475 [CronLifecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler.
> ...
> Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main, SchedulerMain] Application run() exited.
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/
-----------------------------------------------------------
(Updated June 15, 2018, 1:59 p.m.)
Review request for Aurora, David McLaughlin and Jordan Ly.
Changes
-------
- style fix
Bugs: AURORA-1990
https://issues.apache.org/jira/browse/AURORA-1990
Repository: aurora
Description
-------
Convert SlaManager into an AbstractIdleService and explicitly
close the AsyncHttpClient on scheduler shutdown. Otherwise
we run the rise of having a stuck scheduler JVM that is unable
to shutdown due to any on the remaining non-daemon http client
threads.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
Diff: https://reviews.apache.org/r/67613/diff/3/
Changes: https://reviews.apache.org/r/67613/diff/2-3/
Testing
-------
./gradlew test
**Tested in vagrant:**
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.456 [BlockingDriverJoin, StateMachine] SchedulerLifecycle state machine transition DEAD -> DEAD
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.457 [BlockingDriverJoin, SchedulerLifecycle] Shutdown already invoked, ignoring extra call.
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.458 [TearDownShutdownRegistry STOPPING, StateMachine] storage state machine transition READY -> STOPPED
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, Lifecycle] Shutting down application
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, ShutdownRegistry$ShutdownRegistryImpl] Action controller has already completed, subsequent calls ignored.
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.461 [main, SchedulerMain] Stopping scheduler services.
**Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.470 [SlaManager$$EnhancerByGuice$$40d3047 STOPPING, SlaManager] Shutting down SlaManager async http client.**
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.475 [CronLifecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler.
...
Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main, SchedulerMain] Application run() exited.
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204872
-----------------------------------------------------------
Master (8383ed5) is red with this patch.
./build-support/jenkins/build.sh
[189] ./src/main/resources/source-sans-pro.css 1.05 kB {0} [built]
[221] ./src/main/js/index.js 3.43 kB {0} [built]
+ 264 hidden modules
:processResources
:classes
:jar
:moreStartScripts
:startScripts
:distTar
:distZip
:assemble
:compileTestJavaNote: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processTestResources
:testClasses
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java:40:8: Unused import - org.apache.aurora.scheduler.events.Webhook. [UnusedImports]
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 5m 8s
32 actionable tasks: 26 executed, 6 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 15, 2018, 1:55 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 1:55 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/2/
>
>
> Testing
> -------
>
> ./gradlew test
>
> **Tested in vagrant:**
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.456 [BlockingDriverJoin, StateMachine] SchedulerLifecycle state machine transition DEAD -> DEAD
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.457 [BlockingDriverJoin, SchedulerLifecycle] Shutdown already invoked, ignoring extra call.
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.458 [TearDownShutdownRegistry STOPPING, StateMachine] storage state machine transition READY -> STOPPED
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, Lifecycle] Shutting down application
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, ShutdownRegistry$ShutdownRegistryImpl] Action controller has already completed, subsequent calls ignored.
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.461 [main, SchedulerMain] Stopping scheduler services.
> **Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.470 [SlaManager$$EnhancerByGuice$$40d3047 STOPPING, SlaManager] Shutting down SlaManager async http client.**
> Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.475 [CronLifecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler.
> ...
> Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main, SchedulerMain] Application run() exited.
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/
-----------------------------------------------------------
(Updated June 15, 2018, 1:55 p.m.)
Review request for Aurora, David McLaughlin and Jordan Ly.
Changes
-------
Vagrant testing
Bugs: AURORA-1990
https://issues.apache.org/jira/browse/AURORA-1990
Repository: aurora
Description
-------
Convert SlaManager into an AbstractIdleService and explicitly
close the AsyncHttpClient on scheduler shutdown. Otherwise
we run the rise of having a stuck scheduler JVM that is unable
to shutdown due to any on the remaining non-daemon http client
threads.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
Diff: https://reviews.apache.org/r/67613/diff/2/
Testing (updated)
-------
./gradlew test
**Tested in vagrant:**
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.456 [BlockingDriverJoin, StateMachine] SchedulerLifecycle state machine transition DEAD -> DEAD
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.457 [BlockingDriverJoin, SchedulerLifecycle] Shutdown already invoked, ignoring extra call.
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.458 [TearDownShutdownRegistry STOPPING, StateMachine] storage state machine transition READY -> STOPPED
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, Lifecycle] Shutting down application
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.459 [TearDownShutdownRegistry STOPPING, ShutdownRegistry$ShutdownRegistryImpl] Action controller has already completed, subsequent calls ignored.
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.461 [main, SchedulerMain] Stopping scheduler services.
**Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.470 [SlaManager$$EnhancerByGuice$$40d3047 STOPPING, SlaManager] Shutting down SlaManager async http client.**
Jun 15 20:48:53 aurora aurora-scheduler[8719]: I0615 20:48:53.475 [CronLifecycle STOPPING, CronLifecycle] Shutting down Quartz cron scheduler.
...
Jun 15 20:48:56 aurora aurora-scheduler[8719]: I0615 20:48:56.167 [main, SchedulerMain] Application run() exited.
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/
-----------------------------------------------------------
(Updated June 15, 2018, 12:58 p.m.)
Review request for Aurora, David McLaughlin and Jordan Ly.
Changes
-------
- add to scheduler active services
Bugs: AURORA-1990
https://issues.apache.org/jira/browse/AURORA-1990
Repository: aurora
Description
-------
Convert SlaManager into an AbstractIdleService and explicitly
close the AsyncHttpClient on scheduler shutdown. Otherwise
we run the rise of having a stuck scheduler JVM that is unable
to shutdown due to any on the remaining non-daemon http client
threads.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
Diff: https://reviews.apache.org/r/67613/diff/2/
Changes: https://reviews.apache.org/r/67613/diff/1-2/
Testing
-------
./gradlew test
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On June 15, 2018, 11:03 a.m., Jordan Ly wrote:
> > Oops missed one thing:
> >
> > You need to add a scheduler active binding in the module:
> > ```
> > SchedulerServicesModule.addSchedulerActiveServiceBinding(binder())
> > .to([SOMETHING].class);
> > ```
>
> Jordan Ly wrote:
> And for a quick test, can you bring up the scheduler, do an SLA drain with a coordinator, and shut it down and ensure the debug message works correctly?
Testing now. Will post the results shortly.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204858
-----------------------------------------------------------
On June 15, 2018, 11:02 a.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 11:02 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Jordan Ly <jo...@gmail.com>.
> On June 15, 2018, 6:03 p.m., Jordan Ly wrote:
> > Oops missed one thing:
> >
> > You need to add a scheduler active binding in the module:
> > ```
> > SchedulerServicesModule.addSchedulerActiveServiceBinding(binder())
> > .to([SOMETHING].class);
> > ```
And for a quick test, can you bring up the scheduler, do an SLA drain with a coordinator, and shut it down and ensure the debug message works correctly?
- Jordan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204858
-----------------------------------------------------------
On June 15, 2018, 6:02 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 6:02 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204858
-----------------------------------------------------------
Ship it!
Oops missed one thing:
You need to add a scheduler active binding in the module:
```
SchedulerServicesModule.addSchedulerActiveServiceBinding(binder())
.to([SOMETHING].class);
```
- Jordan Ly
On June 15, 2018, 6:02 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 6:02 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204864
-----------------------------------------------------------
Master (8383ed5) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 15, 2018, 6:02 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 6:02 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Bugs: AURORA-1990
> https://issues.apache.org/jira/browse/AURORA-1990
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/
-----------------------------------------------------------
(Updated June 15, 2018, 11:02 a.m.)
Review request for Aurora, David McLaughlin and Jordan Ly.
Bugs: AURORA-1990
https://issues.apache.org/jira/browse/AURORA-1990
Repository: aurora
Description
-------
Convert SlaManager into an AbstractIdleService and explicitly
close the AsyncHttpClient on scheduler shutdown. Otherwise
we run the rise of having a stuck scheduler JVM that is unable
to shutdown due to any on the remaining non-daemon http client
threads.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
Diff: https://reviews.apache.org/r/67613/diff/1/
Testing
-------
./gradlew test
Thanks,
Santhosh Kumar Shanmugham
Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67613/#review204857
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On June 15, 2018, 5:58 p.m., Santhosh Kumar Shanmugham wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67613/
> -----------------------------------------------------------
>
> (Updated June 15, 2018, 5:58 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Jordan Ly.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Convert SlaManager into an AbstractIdleService and explicitly
> close the AsyncHttpClient on scheduler shutdown. Otherwise
> we run the rise of having a stuck scheduler JVM that is unable
> to shutdown due to any on the remaining non-daemon http client
> threads.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 5ad12511e3ec7dda227d133b7e0a2063c352c016
> src/main/java/org/apache/aurora/scheduler/sla/SlaManager.java 98bec4857f1b3c247c24059150de3e4aac080a02
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 07082a99701ea1e428164e76267b908ae20508ad
>
>
> Diff: https://reviews.apache.org/r/67613/diff/1/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Santhosh Kumar Shanmugham
>
>