[GitHub] [spark] cloud-fan commented on a change in pull request #24567: [SPARK-27638][SQL]: date format 'yyyy-M-dd' string comparison not handled properly

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24567: [SPARK-27638][SQL]: date format 'yyyy-M-dd' string comparison not handled properly
URL: https://github.com/apache/spark/pull/24567#discussion_r282918712
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ##########
 @@ -120,11 +120,11 @@ object TypeCoercion {
    */
   private def findCommonTypeForBinaryComparison(
       dt1: DataType, dt2: DataType, conf: SQLConf): Option[DataType] = (dt1, dt2) match {
-    // We should cast all relative timestamp/date/string comparison into string comparisons
+    case (StringType, DateType) => Some(DateType)
+    case (DateType, StringType) => Some(DateType)
+    // We should cast all relative timestamp/string comparison into string comparisons
 
 Review comment:
   if it's justified to do it for date, I think we should do it for timestamp as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org