You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/26 15:56:56 UTC

[GitHub] larroy commented on a change in pull request #13408: Change docker login

larroy commented on a change in pull request #13408: Change docker login
URL: https://github.com/apache/incubator-mxnet/pull/13408#discussion_r236311858
 
 

 ##########
 File path: ci/docker_cache.py
 ##########
 @@ -217,7 +249,11 @@ def script_name() -> str:
     args = parser.parse_args()
 
     platforms = build_util.get_platforms()
-    return build_save_containers(platforms=platforms, registry=args.docker_registry, load_cache=True)
+    try:
 
 Review comment:
   Can we use with idiom? Python context? you can make it a separate PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services