Re: [PR] [GOBBLIN-2053] Add header and fix prefix configs opentelemetry [gobblin]

["phet (via GitHub)" <gi...@apache.org>]

phet commented on code in PR #3933:
URL: https://github.com/apache/gobblin/pull/3933#discussion_r1578431518


##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -913,9 +913,8 @@ public class ConfigurationKeys {
 
   public static final String METRICS_REPORTING_OPENTELEMETRY_ENDPOINT = METRICS_REPORTING_OPENTELEMETRY_PREFIX + "endpoint";
 
-  public static final String METRICS_REPORTING_OPENTELEMETRY_HEADER_KEY = METRICS_REPORTING_OPENTELEMETRY_PREFIX + "header.key";
-
-  public static final String METRICS_REPORTING_OPENTELEMETRY_HEADER_VALUE = METRICS_REPORTING_OPENTELEMETRY_PREFIX + "header.value";
+  // Headers to add to the OpenTelemetry HTTP Exporter, formatted as a JSON String

Review Comment:
   specifically is it supposed to be a JSON dictionary of string, to string?  (whatever it is, doc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org