You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/07/08 13:04:38 UTC
[GitHub] [activemq-artemis] gaohoward commented on a change in pull request #3211: ARTEMIS-2835 Porting HORNETQ-1575 and HORNETQ-1578
gaohoward commented on a change in pull request #3211:
URL: https://github.com/apache/activemq-artemis/pull/3211#discussion_r451527974
##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java
##########
@@ -682,12 +689,32 @@ public ClientSessionFactory createSessionFactory() throws ActiveMQException {
try {
if (e.getType() == ActiveMQExceptionType.NOT_CONNECTED) {
attempts++;
-
- int connectorsSize = getConnectorsSize();
int maxAttempts = config.initialConnectAttempts == 0 ? 1 : config.initialConnectAttempts;
- if (config.initialConnectAttempts >= 0 && attempts >= maxAttempts * connectorsSize) {
- throw ActiveMQClientMessageBundle.BUNDLE.cannotConnectToServers();
+ if (shouldTryStatic) {
+ //we know static is used
+ if (config.initialConnectAttempts >= 0 && attempts >= maxAttempts * this.getNumInitialConnectors()) {
+ if (topologyArrayTried) {
+ //stop retry and throw exception
+ throw ActiveMQClientMessageBundle.BUNDLE.cannotConnectToServers();
+ } else {
+ //lets try topologyArray
+ staticTried = true;
+ shouldTryStatic = false;
+ attempts = 0;
+ }
+ }
+ } else {
+ //we know topologyArray is used
+ if (config.initialConnectAttempts >= 0 && attempts >= maxAttempts * getConnectorsSize()) {
+ if (staticTried) {
+ throw ActiveMQClientMessageBundle.BUNDLE.cannotConnectToServers();
+ } else {
+ topologyArrayTried = true;
+ shouldTryStatic = true;
+ attempts = 0;
+ }
+ }
}
if (factory.waitForRetry(config.retryInterval)) {
Review comment:
actually I somehow removed the line
if (factory.waitForRetry(config.retryInterval)) {
...blah blah
During porting. It makes no sense. I guess I mistakenly removed it during porting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org