You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 05:25:42 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #24804: Add note about how dag policy works with default_args parameter.

uranusjr commented on code in PR #24804:
URL: https://github.com/apache/airflow/pull/24804#discussion_r912636047


##########
docs/apache-airflow/concepts/cluster-policies.rst:
##########
@@ -54,6 +54,8 @@ This policy checks if each DAG has at least one tag defined:
 
     To avoid import cycles, if you use ``DAG`` in type annotations in your cluster policy, be sure to import from ``airflow.models`` and not from ``airflow``.
 
+    DAG policies are applied after the DAG has been completely loaded, so overriding the ``default_args`` parameter will have no effect. If you want to override the default operator settings, consider to use task policies.

Review Comment:
   We should do this in a [callout block](https://docutils.sourceforge.io/docs/ref/rst/directives.html#warning).
   
   LGTM otherwise. Thanks a ton!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org