[jira] [Commented] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649305#comment-16649305 ] 

ASF GitHub Bot commented on FLINK-5486:
---------------------------------------

GJL commented on issue #4356: [FLINK-5486] Fix lacking of synchronization in BucketingSink#handleRe…
URL: https://github.com/apache/flink/pull/4356#issuecomment-429608448
 
 
   I am closing this PR because [FLINK-5486](https://issues.apache.org/jira/browse/FLINK-5486?focusedCommentId=16649304&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16649304) got closed. Please reopen the ticket/PR if you disagree.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Lack of synchronization in BucketingSink#handleRestoredBucketState()
> --------------------------------------------------------------------
>
>                 Key: FLINK-5486
>                 URL: https://issues.apache.org/jira/browse/FLINK-5486
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 1.5.0, 1.4.2, 1.6.0
>            Reporter: Ted Yu
>            Assignee: zhangminglei
>            Priority: Major
>
> Here is related code:
> {code}
>       handlePendingFilesForPreviousCheckpoints(bucketState.pendingFilesPerCheckpoint);
>       synchronized (bucketState.pendingFilesPerCheckpoint) {
>         bucketState.pendingFilesPerCheckpoint.clear();
>       }
> {code}
> The handlePendingFilesForPreviousCheckpoints() call should be enclosed inside the synchronization block. Otherwise during the processing of handlePendingFilesForPreviousCheckpoints(), some entries of the map may be cleared.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)