You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2023/01/19 10:48:07 UTC
[GitHub] [incubator-celeborn] nafiyAix opened a new pull request, #1174: [CELEBORN-229][FOLLOWUP] Support collect metrics with customized labels
nafiyAix opened a new pull request, #1174:
URL: https://github.com/apache/incubator-celeborn/pull/1174
### What changes were proposed in this pull request?
Modify API to ensure they can find metrics with labels.
### Why are the changes needed?
After supporting metrics with customized label, there will be some scenario that metrics has same name but their labels are different(such as user consumed quota), currently when storing NamedTimer, NamedCounter and NamedHistogram(not implemented yet) Celeborn only use metric name to deduplicate, we should keep the uniqueness of named metrics based on both metrics name and label.
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1174: [CELEBORN-229][FOLLOWUP] Support collect metrics with customized labels
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1174:
URL: https://github.com/apache/incubator-celeborn/pull/1174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1174: [CELEBORN-229][FOLLOWUP] Support collect metrics with customized labels
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1174:
URL: https://github.com/apache/incubator-celeborn/pull/1174#issuecomment-1396786569
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1174](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63e57ad) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/e09b629da21e31e755a32fdaee646e3e4dc51948?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e09b629) will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #1174 +/- ##
============================================
- Coverage 27.06% 27.02% -0.04%
+ Complexity 764 762 -2
============================================
Files 200 201 +1
Lines 17195 17211 +16
Branches 1863 1864 +1
============================================
- Hits 4652 4649 -3
- Misses 12225 12241 +16
- Partials 318 321 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/celeborn/common/metrics/MetricLabels.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3MvTWV0cmljTGFiZWxzLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...eleborn/common/metrics/source/AbstractSource.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL0Fic3RyYWN0U291cmNlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `77.93% <0.00%> (+1.36%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1174: [CELEBORN-229][FOLLOWUP] Support collect metrics with customized labels
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1174:
URL: https://github.com/apache/incubator-celeborn/pull/1174#issuecomment-1407275116
ping @waitinfuture , could you take a look if this change will have other impacts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1174: [CELEBORN-229][FOLLOWUP] Support collect metrics with customized labels
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1174:
URL: https://github.com/apache/incubator-celeborn/pull/1174#discussion_r1089630457
##########
common/src/main/scala/org/apache/celeborn/common/metrics/MetricLabels.scala:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.common.metrics
+
+private[metrics] trait MetricLabels {
+ val labels: Map[String, String]
+
+ def labelString: String = MetricLabels.labelString(labels)
+}
+
+object MetricLabels {
+ def labelString(labels: Map[String, String]): String = {
Review Comment:
This method should ensure that if two maps contain the same entries, the return value should be identical. However HashMaps don't guarantee order. I think we can simply sort the strings before concat together(under the assumption that the labels will not be too many)
```
labels.map { case (key: String, value: String) => s"""$key="$value"""" }.toList.sorted.mkString
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org