You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/13 06:26:05 UTC
[GitHub] [spark] rangadi commented on a diff in pull request #39550: [SQL][PROTOBUF] Add missing options for Protobuf functions
rangadi commented on code in PR #39550:
URL: https://github.com/apache/spark/pull/39550#discussion_r1068975468
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/functions.scala:
##########
@@ -36,7 +36,8 @@ object functions {
* @param messageName
* the protobuf message name to look for in descriptorFile.
* @param descFilePath
- * the protobuf descriptor in Message GeneratedMessageV3 format.
+ * the protobuf descriptor file.
Review Comment:
Removed `GeneratedMessageV3` from descriptions in multiple places. It matters only for Java classes. In addition we support both V2 and V3 protobuf syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org