[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #13317: Add source env list in common.properties

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #13317:
URL: https://github.com/apache/dolphinscheduler/pull/13317#discussion_r1061327827


##########
dolphinscheduler-common/src/main/resources/common.properties:
##########
@@ -124,4 +124,7 @@ ml.mlflow.preset_repository=https://github.com/apache/dolphinscheduler-mlflow
 ml.mlflow.preset_repository_version="main"
 
 # way to collect applicationId: log(original regex match), aop
-appId.collect: log
\ No newline at end of file
+appId.collect: log
+
+# The default env list will be load by Shell task
+shell.env_source_list=/etc/profile,~/.bash_profile

Review Comment:
   Do you have a good idea? If we remove the default, in most of the system the task might not work well, due to missing env.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org