You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/15 15:38:07 UTC
[GitHub] [bookkeeper] horizonzy opened a new pull request, #3335: Pre break loop when self create layoutZNode succeed.
horizonzy opened a new pull request, #3335:
URL: https://github.com/apache/bookkeeper/pull/3335
Pre break loop when self create layoutZNode succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy closed pull request #3335: Pre break loop when self create layoutZNode succeed.
Posted by GitBox <gi...@apache.org>.
horizonzy closed pull request #3335: Pre break loop when self create layoutZNode succeed.
URL: https://github.com/apache/bookkeeper/pull/3335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3335: Pre break loop when self create layoutZNode succeed.
Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #3335:
URL: https://github.com/apache/bookkeeper/pull/3335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3335: Pre break loop when self create layoutZNode succeed.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3335:
URL: https://github.com/apache/bookkeeper/pull/3335#issuecomment-1194928606
> I think this change is not necessary
It can reduce once to invoke `zkc.exists(layoutZNode, false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3335: Pre break loop when self create layoutZNode succeed.
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3335:
URL: https://github.com/apache/bookkeeper/pull/3335#issuecomment-1193452584
@horizonzy Would you please rebase the master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #3335: Pre break loop when self create layoutZNode succeed.
Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #3335:
URL: https://github.com/apache/bookkeeper/pull/3335#issuecomment-1159012219
> It would be clearer to add the break just after the node creation, line 190
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org