You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2019/02/26 16:34:00 UTC
[jira] [Commented] (HADOOP-15990) S3AFileSystem.verifyBucketExists
to move to s3.doesBucketExistV2
[ https://issues.apache.org/jira/browse/HADOOP-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778160#comment-16778160 ]
Steve Loughran commented on HADOOP-15990:
-----------------------------------------
checked this, not merging any more
{code}
Checking patch hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java...
Hunk #1 succeeded at 34 (offset 2 lines).
Checking patch hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java...
error: while searching for:
initCannedAcls(conf);
verifyBucketExists();
serverSideEncryptionAlgorithm = getEncryptionAlgorithm(bucket, conf);
inputPolicy = S3AInputPolicy.getPolicy(
error: patch failed: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:308
error: repository lacks the necessary blob to fall back on 3-way merge.
error: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: patch does not apply
Checking patch hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/MockS3ClientFactory.java...
error: while searching for:
final String bucket,
final AWSCredentialsProvider credentialSet) {
AmazonS3 s3 = mock(AmazonS3.class);
when(s3.doesBucketExist(bucket)).thenReturn(true);
// this listing is used in startup if purging is enabled, so
// return a stub value
error: patch failed: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/MockS3ClientFactory.java:39
error: repository lacks the necessary blob to fall back on 3-way merge.
error: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/MockS3ClientFactory.java: patch does not apply
Checking patch hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3ABucketVerifyV2.java...
{code}
> S3AFileSystem.verifyBucketExists to move to s3.doesBucketExistV2
> ----------------------------------------------------------------
>
> Key: HADOOP-15990
> URL: https://issues.apache.org/jira/browse/HADOOP-15990
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.2.0
> Reporter: Steve Loughran
> Assignee: lqjacklee
> Priority: Major
> Attachments: HADOOP-15409-005.patch, HADOOP-15990-006.patch
>
>
> in S3AFileSystem.initialize(), we check for the bucket existing with verifyBucketExists(), which calls s3.doesBucketExist(). But that doesn't check for auth issues.
> s3. doesBucketExistV2() does at least validate credentials, and should be switched to. This will help things fail faster
> See SPARK-24000
> (this is a dupe of HADOOP-15409; moving off git PRs so we can get yetus to test everything)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org