You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by peter-toth <gi...@git.apache.org> on 2018/10/25 18:28:33 UTC

[GitHub] spark pull request #22817: [SPARK-25816][SQL] Fix attribute resolution in ne...

Github user peter-toth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22817#discussion_r228285647
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala ---
    @@ -407,7 +407,10 @@ case class ResolvedStar(expressions: Seq[NamedExpression]) extends Star with Une
      *                   can be key of Map, index of Array, field name of Struct.
      */
     case class UnresolvedExtractValue(child: Expression, extraction: Expression)
    -  extends UnaryExpression with Unevaluable {
    +  extends BinaryExpression with Unevaluable {
    --- End diff --
    
    if this change is not allowed then `children` we can override `children` instead


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org