You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/11 13:23:37 UTC

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #171: docs: use make cmd instead of docker build cmd

membphis commented on a change in pull request #171:
URL: https://github.com/apache/apisix-ingress-controller/pull/171#discussion_r555042594



##########
File path: docs/install.md
##########
@@ -71,7 +71,7 @@ helm install ingress-apisix -n ingress-apisix ./charts/ingress-apisix
 ## Master branch builds
 
 ```shell
-docker build -t apache/ingress-controller:v0.1.0 ../.
+cd .. && make build-image

Review comment:
       why do we need `cd .. &&` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org