[GitHub] [incubator-pinot] chenboat commented on pull request #5905: Add 0.5 license and notice.

[GitBox <gi...@apache.org>]

chenboat commented on pull request #5905:
URL: https://github.com/apache/incubator-pinot/pull/5905#issuecomment-680687103


   Thanks for the reviews. 
   (1) org.apache.helix:helix-core:0.9.7 is still in the LICENSE-binary file. 
   (2) cddl 1.0 should _not_ go away. I think the current runbook has ambiguity in it (quote below)
      "**Scroll down to the section on the project's compile dependencies (transitive)**"       
      The javax.servlet-api is the direct compile dependencies and thus it is NOT shown up in the transitive dep list. We should modify the instruction to include direct dependencies.
       gpl will still go away as its jar got deleted completed — I can mentioned it in the commit msg.
   
   > Looks ok overall, but a few questions. If you can add that in the commit message that will be useful.
   > (1) Why did Apache Helix go away from LICENSE-binary?
   > (2) Why did cddl and gpl license go away?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org